-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: AnalyzeV2 supports processing special global indexes #56115
Conversation
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f984ce8
to
4c8a7d0
Compare
/retest |
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56115 +/- ##
================================================
+ Coverage 73.4587% 76.2802% +2.8215%
================================================
Files 1605 1627 +22
Lines 444802 453922 +9120
================================================
+ Hits 326746 346253 +19507
+ Misses 98001 86332 -11669
- Partials 20055 21337 +1282
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
/hold
Feel free to unhold it after you fix them. Or feel free to cc me to look at it again.
[LGTM Timeline notifier]Timeline:
|
But don't forget to add the comments requested by Rustin. |
664d40c
to
6faeed4
Compare
@Defined2014: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rustin170506, tangenta, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #54233
Problem Summary:
Supports processing global index in analyze version V2. Because the data of the global index is not scattered in every partitions, only one analyze is required for the whole table.
Because we use an independent index analyze task, there will be results of the same version when saving, which needs to be processed like mv index.
After the analysis is complete, the global index will only have global stats.
AutoAnalyze will not process global index, user should trigger it manually.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.