Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support to query init stats percentage from http api #55323

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 9, 2024

What problem does this PR solve?

Issue Number: close #53564

Problem Summary:

What changed and how does it work?

Add progress information in the status.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
➜  opensource curl http://127.0.0.1:9081/status
{"connections":0,"version":"8.0.11-TiDB-v8.3.0-alpha-129-g158199c87d","git_hash":"158199c87d9bb83e045e4e113d38d323006ea41d","status":{"init_stats_percentage":100}}
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner and removed do-not-merge/needs-tests-checked labels Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 70.5509%. Comparing base (b066365) to head (e710229).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55323        +/-   ##
================================================
- Coverage   74.7027%   70.5509%   -4.1519%     
================================================
  Files          1570       1570                
  Lines        364767     437229     +72462     
================================================
+ Hits         272491     308469     +35978     
- Misses        72509     108181     +35672     
- Partials      19767      20579       +812     
Flag Coverage Δ
integration 48.7711% <11.1111%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.1894% <ø> (ø)
parser ∅ <ø> (∅)
br 57.8048% <ø> (+10.1871%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 9, 2024
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

for domain part

@ti-chi-bot ti-chi-bot bot added the approved label Aug 9, 2024
@hawkingrei hawkingrei added the lgtm label Aug 9, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 9, 2024
@lance6716
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2024
Copy link

ti-chi-bot bot commented Aug 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-09 05:11:07.427599603 +0000 UTC m=+587997.294698694: ☑️ agreed by winoros.
  • 2024-08-09 07:12:04.637271943 +0000 UTC m=+595254.504371033: ☑️ agreed by lance6716.

Copy link

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit fd3ad81 into pingcap:master Aug 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing the progress of loading initial stats
3 participants