Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: Use full name instead of prefix in integration test #54811

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Jul 22, 2024

What problem does this PR solve?

Issue Number: close #54820

Problem Summary:

Pd-ctl now disabled the prefix matching, we may need to adapt the modification.
ref: tikv/pd#8414

What changed and how does it work?

Use full command instead of prefix matching in pd-ctl command.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2024
Copy link

tiprow bot commented Jul 22, 2024

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this file as well :)

echo "add shuffle-region-scheduler"
run_pd_ctl -u https://$PD_ADDR sched add shuffle-region-scheduler
# backup with shuffle region
echo "backup start..."
run_br --pd $PD_ADDR backup table -s "local://$TEST_DIR/$DB" --db $DB -t $TABLE
run_sql "DROP TABLE $DB.$TABLE;"
# restore with shuffle region
echo "restore start..."
run_br restore table --db $DB --table $TABLE -s "local://$TEST_DIR/$DB" --pd $PD_ADDR
# remove shuffle region scheduler
run_pd_ctl -u https://$PD_ADDR sched remove shuffle-region-scheduler

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.4761%. Comparing base (60cc666) to head (3628c73).
Report is 5 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54811         +/-   ##
=================================================
- Coverage   72.7687%   56.4761%   -16.2927%     
=================================================
  Files          1555       1680        +125     
  Lines        437788     611811     +174023     
=================================================
+ Hits         318573     345527      +26954     
- Misses        99617     242536     +142919     
- Partials      19598      23748       +4150     
Flag Coverage Δ
integration 38.2548% <ø> (?)
unit 71.7399% <ø> (-0.0439%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 61.2773% <ø> (+15.4159%) ⬆️

@RidRisR RidRisR requested a review from HuSharp July 23, 2024 03:18
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 23, 2024
Copy link

ti-chi-bot bot commented Jul 23, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 23, 2024
Copy link

ti-chi-bot bot commented Jul 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-23 03:21:08.092643185 +0000 UTC m=+928890.083584655: ☑️ agreed by Leavrth.
  • 2024-07-23 03:25:42.764172303 +0000 UTC m=+929164.755113775: ☑️ agreed by YuJuncen.

@HuSharp
Copy link
Contributor

HuSharp commented Jul 23, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit 6df905b into pingcap:master Jul 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: pd-ctl don't have command "sched"
4 participants