-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: Use full name instead of prefix in integration test #54811
Conversation
Hi @RidRisR. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this file as well :)
tidb/br/tests/br_shuffle_region/run.sh
Lines 29 to 43 in 301357e
echo "add shuffle-region-scheduler" | |
run_pd_ctl -u https://$PD_ADDR sched add shuffle-region-scheduler | |
# backup with shuffle region | |
echo "backup start..." | |
run_br --pd $PD_ADDR backup table -s "local://$TEST_DIR/$DB" --db $DB -t $TABLE | |
run_sql "DROP TABLE $DB.$TABLE;" | |
# restore with shuffle region | |
echo "restore start..." | |
run_br restore table --db $DB --table $TABLE -s "local://$TEST_DIR/$DB" --pd $PD_ADDR | |
# remove shuffle region scheduler | |
run_pd_ctl -u https://$PD_ADDR sched remove shuffle-region-scheduler |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54811 +/- ##
=================================================
- Coverage 72.7687% 56.4761% -16.2927%
=================================================
Files 1555 1680 +125
Lines 437788 611811 +174023
=================================================
+ Hits 318573 345527 +26954
- Misses 99617 242536 +142919
- Partials 19598 23748 +4150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-issue-triage-complete |
What problem does this PR solve?
Issue Number: close #54820
Problem Summary:
Pd-ctl now disabled the prefix matching, we may need to adapt the modification.
ref: tikv/pd#8414
What changed and how does it work?
Use full command instead of prefix matching in pd-ctl command.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.