-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore: make incremental restore and log restore compatible #54473
restore: make incremental restore and log restore compatible #54473
Conversation
Skipping CI for Draft Pull Request. |
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for ddl part
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54473 +/- ##
=================================================
- Coverage 72.8476% 56.8557% -15.9920%
=================================================
Files 1542 1670 +128
Lines 436136 614701 +178565
=================================================
+ Hits 317715 349493 +31778
- Misses 98837 241325 +142488
- Partials 19584 23883 +4299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
br/pkg/task/restore.go
Outdated
@@ -237,6 +239,10 @@ type RestoreConfig struct { | |||
// if it is empty, directly take restoring log justly. | |||
FullBackupStorage string `json:"full-backup-storage" toml:"full-backup-storage"` | |||
|
|||
// LogIncrementalCompat indicates whether this restore should enter a compatibility mode for incremental restore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// LogIncrementalCompat indicates whether this restore should enter a compatibility mode for incremental restore. | |
// AllowPITRFromIncremental indicates whether this restore should enter a compatibility mode for incremental restore. |
/test pull-br-integration-test |
@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold for test passed |
/test check-dev2 |
@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev2 |
@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth, tangenta, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/retest |
@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #54474
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility
In order to protect data not loss for later log restore, the new add option during incremental restore will perform a strict check for ddls by default. which means the restore could fail due to unsupported backfill ddl types appeared. such as Add Index/Modify Column/Reorg Partition.
Documentation https://github.com/pingcap/docs-cn/pull/17893/files
Affects user behaviors
Contains syntax changes
Contains variable changes
Contains experimental features
Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.