-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, expr: eval readonly user var during plan phase #54462
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1dfbb1c
to
3830760
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54462 +/- ##
=================================================
- Coverage 72.8631% 56.0074% -16.8557%
=================================================
Files 1544 1665 +121
Lines 436218 608423 +172205
=================================================
+ Hits 317842 340762 +22920
- Misses 98816 244344 +145528
- Partials 19560 23317 +3757
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3830760
to
cddf002
Compare
cddf002
to
0561371
Compare
0561371
to
c8dc5cb
Compare
@winoros: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #52742, #8733, #14231, #24276
Problem Summary:
What changed and how does it work?
If a user var is not affected by
setvar
at SQL level, we can directly use its value. No need to wrap it withgetvar
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.