Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc: delete TiFlash placement rules in batch (#54071) #54406

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54071

What problem does this PR solve?

Issue Number: close #54068

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Improve performance of GC worker by deleting TiFlash placement rules in batch

@ti-chi-bot ti-chi-bot added release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 labels Jul 3, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 3, 2024
@Lloyd-Pottiger
Copy link
Contributor

/retest

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@f40e38f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #54406   +/-   ##
================================================
  Coverage               ?   71.1739%           
================================================
  Files                  ?       1465           
  Lines                  ?     421587           
  Branches               ?          0           
================================================
  Hits                   ?     300060           
  Misses                 ?     101048           
  Partials               ?      20479           
Flag Coverage Δ
unit 71.1739% <84.6153%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0288% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jul 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 06:34:33.337586596 +0000 UTC m=+339370.572820709: ☑️ agreed by GMHDBJD.
  • 2024-07-10 08:13:33.922564027 +0000 UTC m=+431711.157798144: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit b90e57a into pingcap:release-8.1 Jul 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants