-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: support right outer join for hash join v2 #54405
Conversation
Hi @wshwsh12. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54405 +/- ##
=================================================
- Coverage 72.7982% 57.3036% -15.4947%
=================================================
Files 1542 1671 +129
Lines 436141 617741 +181600
=================================================
+ Hits 317503 353988 +36485
- Misses 98999 240109 +141110
- Partials 19639 23644 +4005
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3a256bd
to
d4102ea
Compare
// For left out join, left side is outer side, and right side is inner side. | ||
// For right out join, right side is outer side, and left side is inner side. | ||
isOuterSideBuild bool | ||
// used when build inner side, isNotMatchedRows is indexed by logical row index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// used when build inner side, isNotMatchedRows is indexed by logical row index | |
// used when use inner side to build, isNotMatchedRows is indexed by logical row index |
isNotMatchedRows []bool | ||
// used when build left side | ||
// used when build outer side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// used when build outer side | |
// used when use outer side to build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, windtalker, xzhangxian1008 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@wshwsh12: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #53127
Problem Summary:
What changed and how does it work?
Support right outer join for hash join v2.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.