Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support right outer join for hash join v2 #54405

Merged
merged 18 commits into from
Jul 13, 2024

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Jul 3, 2024

What problem does this PR solve?

Issue Number: ref #53127

Problem Summary:

What changed and how does it work?

Support right outer join for hash join v2.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Jul 3, 2024
Copy link

tiprow bot commented Jul 3, 2024

Hi @wshwsh12. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.3036%. Comparing base (bf50430) to head (89e92c1).
Report is 42 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54405         +/-   ##
=================================================
- Coverage   72.7982%   57.3036%   -15.4947%     
=================================================
  Files          1542       1671        +129     
  Lines        436141     617741     +181600     
=================================================
+ Hits         317503     353988      +36485     
- Misses        98999     240109     +141110     
- Partials      19639      23644       +4005     
Flag Coverage Δ
integration 57.4155% <94.7368%> (?)
unit 72.6377% <94.7368%> (+0.8289%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2268% <ø> (+17.3828%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2024
// For left out join, left side is outer side, and right side is inner side.
// For right out join, right side is outer side, and left side is inner side.
isOuterSideBuild bool
// used when build inner side, isNotMatchedRows is indexed by logical row index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// used when build inner side, isNotMatchedRows is indexed by logical row index
// used when use inner side to build, isNotMatchedRows is indexed by logical row index

isNotMatchedRows []bool
// used when build left side
// used when build outer side
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// used when build outer side
// used when use outer side to build

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jul 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 03:19:12.703166107 +0000 UTC m=+327649.938400221: ☑️ agreed by windtalker.
  • 2024-07-12 02:57:35.292273378 +0000 UTC m=+585552.527507503: ☑️ agreed by xzhangxian1008.

Copy link

ti-chi-bot bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 12, 2024
@wshwsh12
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jul 13, 2024

@wshwsh12: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 1ce4236 into pingcap:master Jul 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants