-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix empty SQL in slow log for internal statement (#54274) #54309
*: fix empty SQL in slow log for internal statement (#54274) #54309
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54309 +/- ##
================================================
Coverage ? 71.5714%
================================================
Files ? 1465
Lines ? 425772
Branches ? 0
================================================
Hits ? 304731
Misses ? 100634
Partials ? 20407
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[LGTM Timeline notifier]Timeline:
|
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, xhebox, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #54274
What problem does this PR solve?
Issue Number: close #54190 , close #52743 , close #53264
What changed and how does it work?
The internal session does not init
EnableRedactLog
which causeredact.String
always returns empty string.Init it as an default value in this PR.
Check List
Tests
And check the output slow logs. No empty strings again.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.