Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: reduce memory allocation in the initialization of hash agg executor #54127

Merged
merged 17 commits into from
Oct 8, 2024

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Jun 20, 2024

What problem does this PR solve?

Issue Number: close #53898

Problem Summary:

What changed and how does it work?

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2024
Copy link

tiprow bot commented Jun 20, 2024

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/cc @hawkingrei @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested review from hawkingrei and XuHuaiyu June 20, 2024 03:56
@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jun 20, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jun 21, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.9053%. Comparing base (f73e3e3) to head (4dfe152).
Report is 358 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54127        +/-   ##
================================================
+ Coverage   72.8881%   78.9053%   +6.0172%     
================================================
  Files          1576       1687       +111     
  Lines        440774     531368     +90594     
================================================
+ Hits         321272     419278     +98006     
+ Misses        99762      91379      -8383     
- Partials      19740      20711       +971     
Flag Coverage Δ
integration 53.8929% <100.0000%> (?)
unit 76.1899% <100.0000%> (+4.2331%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.7090% <ø> (+1.7522%) ⬆️
parser ∅ <ø> (∅)
br 55.5022% <ø> (+9.5083%) ⬆️

@xzhangxian1008
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2024
@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jun 24, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/retest

1 similar comment
@xzhangxian1008
Copy link
Contributor Author

/retest

@xzhangxian1008
Copy link
Contributor Author

/retest

@xzhangxian1008
Copy link
Contributor Author

/cc @hawkingrei

Copy link

tiprow bot commented Jul 8, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 8, 2024
@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

1 similar comment
@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test result after this improvement can be shown?

pkg/util/chunk/chunk.go Outdated Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

Any test result after this improvement can be shown?

test result has been updated in the pr description.

@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested a review from XuHuaiyu July 15, 2024 01:21
@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

3 similar comments
@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-08 01:49:09.457781434 +0000 UTC m=+235846.693015548: ☑️ agreed by hawkingrei.
  • 2024-10-08 01:28:08.119947292 +0000 UTC m=+923043.540160303: ☑️ agreed by windtalker.

Copy link

tiprow bot commented Oct 8, 2024

@xzhangxian1008: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 4dfe152 link true /test tidb_parser_test
fast_test_tiprow 4dfe152 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 7252cd4 into pingcap:master Oct 8, 2024
21 of 23 checks passed
@xzhangxian1008 xzhangxian1008 deleted the fix-53898 branch October 8, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(*HashAggExec).initForParallelExec is too slow
4 participants