-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: Add a GetDBMeta function to meta. #53684
Conversation
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Hi @asddongmen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: dongmen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53684 +/- ##
=================================================
- Coverage 74.4884% 55.8330% -18.6554%
=================================================
Files 1506 1626 +120
Lines 357618 606999 +249381
=================================================
+ Hits 266384 338906 +72522
- Misses 71857 244923 +173066
- Partials 19377 23170 +3793
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold |
what kind of filter will CDC use? |
Signed-off-by: dongmen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Co-authored-by: D3Hunter <[email protected]>
Co-authored-by: D3Hunter <[email protected]>
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, D3Hunter, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@asddongmen: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #53685
Problem Summary:
What changed and how does it work?
Add a function named
GetDBMeta
to meta.go. This function will allow the caller to get all raw tableInfos of database.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.