-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ranger: handle float/integers overflow properly (#53501) #53521
ranger: handle float/integers overflow properly (#53501) #53521
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #53521 +/- ##
================================================
Coverage ? 73.6502%
================================================
Files ? 1096
Lines ? 351780
Branches ? 0
================================================
Hits ? 259087
Misses ? 76026
Partials ? 16667 |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
e66add0
to
d28be63
Compare
Signed-off-by: Weizhen Wang <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
This is an automated cherry-pick of #53501
What problem does this PR solve?
Issue Number: close #46538
ref #50489
Problem Summary:
What changed and how does it work?
float/integers would be returned if overflow error occurs, so convertPoint would adjust the excl of the boundary accordingly, and impossible ranges would be removed by consequent validIntervals().
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.