-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tablecodec: fix the issue that decoding an index value might panic (#53034) #53446
tablecodec: fix the issue that decoding an index value might panic (#53034) #53446
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@zyguan Please resolve the conflicts |
Signed-off-by: zyguan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53446 +/- ##
================================================
Coverage ? 72.4241%
================================================
Files ? 1411
Lines ? 414884
Branches ? 0
================================================
Hits ? 300476
Misses ? 94468
Partials ? 19940
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
/merge |
@zyguan: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, crazycs520, MyonKeminta, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #53034
What problem does this PR solve?
Issue Number: close #47115
Problem Summary: decoding an index value with large padding size might panic, because the padding size is:
types.NewUintDatum(paddingSize) => encodeUint
decodeRestoredValuesV5 => rd.DecodeToBytesNoHandle => rd.encodeOldDatum(IntFlag) => codec.EncodeVarint(buf, decodeInt(raw))
because the field type is not marked as unsigned inbuildRestoredColumn
.What changed and how does it work?
Set unsigned flag to the field type correctly.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.