Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: watch store state and retry backup immediately #53341

Merged
merged 46 commits into from
Jun 6, 2024

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented May 17, 2024

What problem does this PR solve?

Issue Number: close #52534
close #53519
Problem Summary:

What changed and how does it work?

  1. reuse storewatch to observe store change event to retry backup.
  2. refine main backup code for easy to test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented May 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@3pointer 3pointer requested review from YuJuncen and Leavrth May 20, 2024 10:55
br/pkg/backup/client.go Outdated Show resolved Hide resolved
br/pkg/backup/client.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 4, 2024
Copy link

ti-chi-bot bot commented Jun 4, 2024

@Leavrth: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer
Copy link
Contributor Author

3pointer commented Jun 4, 2024

/test unit-test

Copy link

tiprow bot commented Jun 4, 2024

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2024
Copy link

ti-chi-bot bot commented Jun 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-04 02:22:17.20906223 +0000 UTC m=+3347890.966197820: ☑️ agreed by Leavrth.
  • 2024-06-06 02:24:34.23719237 +0000 UTC m=+3520827.994327943: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit dcadcde into pingcap:master Jun 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
3 participants