extension: make RelatedTables work when the statement fails (#50989)
#53309
+479
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
release-note
13 tasks
ti-chi-bot
added
the
cherry-pick-approved
CbcWestwolf
force-pushed
the
cherry-pick-50989-to-release-7.1
branch
from
59b3720
to
6a05d45
Compare
|
/retest |
CbcWestwolf
force-pushed
the
cherry-pick-50989-to-release-7.1
branch
2 times, most recently
from
a69c8ce
to
99f5686
Compare
|
/retest |
1 similar comment
|
/retest |
wuhuizuo
reviewed
May 16, 2024
planner/core/util_test.go
Outdated
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/pingcap/tidb/pkg/parser" |
There was a problem hiding this comment.
Suggested change
| "github.com/pingcap/tidb/pkg/parser" | |
| "github.com/pingcap/tidb/parser" |
CbcWestwolf
force-pushed
the
cherry-pick-50989-to-release-7.1
branch
from
99f5686
to
8eae2ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #53309 +/- ##
================================================
Coverage ? 73.4436%
================================================
Files ? 1211
Lines ? 380192
Branches ? 0
================================================
Hits ? 279227
Misses ? 83138
Partials ? 17827 |
CbcWestwolf
approved these changes
May 16, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/approve |
D3Hunter
approved these changes
May 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #50989
What problem does this PR solve?
Issue Number: close #50988
Problem Summary:
What changed and how does it work?
If the statement fails (
err != nilinRelatedTables), traverse the AST to get all table names.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.