Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Fix push downed topN won't replace correlated column problem (#53097) #53153

Merged
merged 2 commits into from
May 10, 2024
Merged

executor: Fix push downed topN won't replace correlated column problem (#53097) #53153

merged 2 commits into from
May 10, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53097

What problem does this PR solve?

Issue Number: close #52777

Problem Summary:
RT

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 10, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 10, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 10, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
@yibin87
Resolve conflict
f5de45c 
Signed-off-by: yibin <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 10, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 10, 2024
windtalker
windtalker approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label May 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-10 07:43:41.220019583 +0000 UTC m=+1207174.977155149: ☑️ agreed by SeaRise.
  • 2024-05-10 07:48:00.841775291 +0000 UTC m=+1207434.598910865: ☑️ agreed by windtalker.

@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-6.5@fe6837a). Click here to learn what that means.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #53153   +/-   ##
================================================
  Coverage               ?   73.6619%           
================================================
  Files                  ?       1096           
  Lines                  ?     351617           
  Branches               ?          0           
================================================
  Hits                   ?     259008           
  Misses                 ?      75976           
  Partials               ?      16633

@ti-chi-bot ti-chi-bot bot merged commit 389b0c1 into pingcap:release-6.5 May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@yibin87 yibin87

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @windtalker @SeaRise @yibin87