-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2323 #53099
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
/test mysql-test |
@elsa0520: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle planner: fix the issue about simplify outer join to inner join (#51750) |
/retest |
/test mysql-test |
@elsa0520: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2266 |
/retest |
/retitle planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pull/2266 |
/retest |
/test mysql-test |
@elsa0520: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2323 |
/retest |
/retest |
/test mysql-test |
@elsa0520: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5-20230625-v6.5.3 #53099 +/- ##
================================================================
Coverage ? 73.5421%
================================================================
Files ? 1080
Lines ? 347280
Branches ? 0
================================================================
Hits ? 255397
Misses ? 75513
Partials ? 16370 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can delete the irrelevant changed tests. Only keep the related one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
0695f1e
into
pingcap:release-6.5-20230625-v6.5.3
This is an automated cherry-pick of #51750
What problem does this PR solve?
Issue Number: close #51560
Problem Summary:
The original codes will push the predicates that are not related to that child.
What changed and how does it work?
Don't do the recursively. Let the predicate-push-down to do the recursively.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.