variable: add all text series types into tidb_analyze_skip_column_types | tidb-test=pr/2319 #52663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
AilinKid
approved these changes
Apr 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52663 +/- ##
================================================
+ Coverage 72.0208% 74.2743% +2.2534%
================================================
Files 1499 1499
Lines 431246 432649 +1403
================================================
+ Hits 310587 321347 +10760
+ Misses 101361 91497 -9864
- Partials 19298 19805 +507
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/approve |
|
/retest |
winoros
approved these changes
Apr 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, easonn7, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
hawkingrei
force-pushed
the
update_tidb_analyze_skip_column_types
branch
from
840bfbe
to
653eff8
Compare
hawkingrei
changed the title
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test all |
hawkingrei
force-pushed
the
update_tidb_analyze_skip_column_types
branch
2 times, most recently
from
f9c12c7
to
bbefa3b
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
force-pushed
the
update_tidb_analyze_skip_column_types
branch
from
bbefa3b
to
764c03c
Compare
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
3AceShowHand
pushed a commit
to 3AceShowHand/tidb
that referenced
this pull request
May 7, 2024
terry1purcell
pushed a commit
to terry1purcell/tidb
that referenced
this pull request
May 17, 2024
RidRisR
pushed a commit
to RidRisR/tidb
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #52636
Problem Summary:
What changed and how does it work?
update the default value of tidb_analyze_skip_column_types and put all text series types into it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.