-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ranger: handle longlong overflow properly #52365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52365 +/- ##
================================================
+ Coverage 72.5278% 74.4993% +1.9714%
================================================
Files 1505 1505
Lines 429901 430063 +162
================================================
+ Hits 311798 320394 +8596
+ Misses 98809 89764 -9045
- Partials 19294 19905 +611
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/retest |
1 similar comment
/retest |
/retest |
@time-and-fate PTAL |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #45783
Problem Summary:
What changed and how does it work?
bigint would be returned if overflow error occurs, so
convertPoint
would adjust theexcl
of the boundary accordingly, and impossible ranges would be removed by consequentvalidIntervals()
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.