-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add memory tracker for memtableRetriever #51455
Conversation
Hi @wshwsh12. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51455 +/- ##
================================================
+ Coverage 70.6985% 73.4099% +2.7114%
================================================
Files 1462 1463 +1
Lines 435210 440890 +5680
================================================
+ Hits 307687 323657 +15970
+ Misses 108225 97086 -11139
- Partials 19298 20147 +849
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -210,6 +211,9 @@ func (e *memtableRetriever) retrieve(ctx context.Context, sctx sessionctx.Contex | |||
return nil, err | |||
} | |||
e.initialized = true | |||
if e.memTracker != nil { | |||
e.memTracker.Consume(calculateDatumsSize(e.rows)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this time, the memory has already been allocated 🤔. Do we have a plan to Consume
progressively in each implementation above?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YangKeao, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@wshwsh12: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@wshwsh12: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@wshwsh12: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #51456
related #51260
Problem Summary:
What changed and how does it work?
Add memory tracker for memtableRetriever
Check List
Tests
Test Case: 50k tables, each table contains 10 columns.
Test1: Testing 'explain analyze' to accurately display memory usage.
Test2: Testing mem-quota to successfully cancel SQL queries exceeding the threshold.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.