Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix possible inconsistent output cols among union's children (#48775) #48898

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented Nov 24, 2023

This is a manual pick.

What problem does this PR solve?

Issue Number: close #48755

Problem Summary:

When UNIONALL's first child, it's possible that the selection is pushed at a position different with other children. This will cause inconsistent output columns among its children.

You can check the changed codes together with https://github.com/pingcap/tidb/blob/master/pkg/planner/core/rule_predicate_push_down.go#L479-L483 for more details.

And the failed case is something like Proj{c1}->UnionAll{c1, c2, c3}->(Select{c2 > 0, c3 > 0}->Proj{c1, c2, c3}, Proj{c1, c2, c3}->Select{c2>0, c3>0}).
UnionALL first only keeps the col c1. But its first child's selection also requires c2 and c3, so the projection of its first children will keep c2 and c3. The second child's projection doesn't need the c2 and c3 since the selection is pushed down.

What is changed and how it works?

We use the UNIONALL's self output columns to do the alignment.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the potential execution failure when UNION ALL's first child is TableDual

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Nov 24, 2023
@winoros winoros added the sig/planner SIG: Planner label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 24, 2023
Copy link

ti-chi-bot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 13:36:09.249116588 +0000 UTC m=+584197.914342785: ☑️ agreed by AilinKid.
  • 2023-11-24 14:06:20.409841719 +0000 UTC m=+586009.075067899: ☑️ agreed by time-and-fate.

@winoros
Copy link
Member Author

winoros commented Nov 24, 2023

/run-unit-test

@hawkingrei
Copy link
Member

/test all

Copy link

tiprow bot commented Nov 24, 2023

@hawkingrei: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor

/test ?

Copy link

ti-chi-bot bot commented Nov 24, 2023

@purelind: The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-6.5/ghpr_build
  • pingcap/tidb/release-6.5/ghpr_check
  • pingcap/tidb/release-6.5/ghpr_check2
  • pingcap/tidb/release-6.5/ghpr_mysql_test
  • pingcap/tidb/release-6.5/ghpr_unit_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Nov 24, 2023

@purelind: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7c76d11 into pingcap:release-6.5 Nov 24, 2023
8 checks passed
@winoros winoros deleted the pick-pr-48775 branch November 24, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants