-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix possible inconsistent output cols among union's children (#48775) #48898
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-unit-test |
/test all |
@hawkingrei: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test ? |
@purelind: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@purelind: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
This is a manual pick.
What problem does this PR solve?
Issue Number: close #48755
Problem Summary:
When UNIONALL's first child, it's possible that the selection is pushed at a position different with other children. This will cause inconsistent output columns among its children.
You can check the changed codes together with https://github.com/pingcap/tidb/blob/master/pkg/planner/core/rule_predicate_push_down.go#L479-L483 for more details.
And the failed case is something like
Proj{c1}->UnionAll{c1, c2, c3}->(Select{c2 > 0, c3 > 0}->Proj{c1, c2, c3}, Proj{c1, c2, c3}->Select{c2>0, c3>0})
.UnionALL first only keeps the col
c1
. But its first child's selection also requiresc2
andc3
, so the projection of its first children will keepc2
andc3
. The second child's projection doesn't need thec2
andc3
since the selection is pushed down.What is changed and how it works?
We use the UNIONALL's self output columns to do the alignment.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.