Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumpling: force sort for table sample | tidb-test=2d8288cf58aec9d381d09da70b18fd27855ed597 #48305

Merged
merged 1 commit into from
Nov 8, 2023
Merged

dumpling: force sort for table sample | tidb-test=2d8288cf58aec9d381d09da70b18fd27855ed597 #48305

merged 1 commit into from
Nov 8, 2023

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #48253

Problem Summary:

What is changed and how it works?

force sort for table sample by using COALESCE.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Manual using dumpling to dump false data and it works now.

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lichunzhu lichunzhu requested a review from a team as a code owner November 6, 2023 04:00
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed component/dumpling This is related to Dumpling of TiDB. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 6, 2023
@tiprow tiprow
Copy link

tiprow bot commented Nov 6, 2023

Hi @lichunzhu. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Nov 6, 2023
@lichunzhu lichunzhu changed the base branch from master to release-6.5-20230425-v6.5.2 November 6, 2023 13:48
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 7, 2023
@lichunzhu
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 7, 2023

@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lichunzhu
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 8, 2023

@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lichunzhu
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 8, 2023

@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GMHDBJD
GMHDBJD approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 8, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-07 01:35:23.988659801 +0000 UTC m=+3521721.575769945: ☑️ agreed by lance6716.
  • 2023-11-08 06:28:21.343706825 +0000 UTC m=+3625698.930816969: ☑️ agreed by GMHDBJD.

@lichunzhu
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 8, 2023

@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lichunzhu
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 8, 2023

@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lichunzhu
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 8, 2023
@purelind purelind changed the title dumpling: force sort for table sample dumpling: force sort for table sample | tidb-test=2d8288cf58aec9d381d09da70b18fd27855ed597 Nov 8, 2023
@purelind
Copy link
Contributor

purelind commented Nov 8, 2023

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 8, 2023

@purelind: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 7a5fd17 into pingcap:release-6.5-20230425-v6.5.2 Nov 8, 2023
8 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #48432.

This was referenced Nov 8, 2023
Closed
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #48433.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48434.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 8, 2023
Closed
1 task
@lichunzhu lichunzhu deleted the forceSortForTableSample branch November 10, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lichunzhu @purelind @ti-chi-bot @lance6716 @GMHDBJD