Skip to content

local backend: fix worker err overriden by job generation err (#48185) #48199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2023
Merged

local backend: fix worker err overriden by job generation err (#48185) #48199

merged 3 commits into from
Nov 2, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48185

What problem does this PR solve?

Issue Number: close #47992

Problem Summary:

What is changed and how it works?

put job generation into the same error group as worker

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    send a dummy job before scan region in generating job, and let worker returns error directly
| 300001 | //small-2.csv | `test`.`t`|148 | importing| failed | 16B  | NULL | [0]the remaining storage capacity of TiKV is less than 10%%; please increase the storage capacity of TiKV and try again | 2023-11-01 17:42:42.330981 | 2023-11-01 17:42:44.665693 | 2023-11-01 17:42:50.674848 | root@%  |
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 1, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 1, 2023
Merged
13 tasks
@D3Hunter
Copy link
Contributor

D3Hunter commented Nov 2, 2023

/lgtm

@D3Hunter
Copy link
Contributor

D3Hunter commented Nov 2, 2023

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 2, 2023
Benjamin2037
Benjamin2037 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-02 02:12:26.480004952 +0000 UTC m=+3091944.067115082: ☑️ agreed by D3Hunter.
  • 2023-11-02 02:14:54.559097951 +0000 UTC m=+3092092.146208118: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4f75469 into pingcap:release-7.5 Nov 2, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-48185-to-release-7.5 branch April 15, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees

@D3Hunter D3Hunter

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @D3Hunter @lance6716 @Benjamin2037