Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: display mDDLTableVersion in mysql.tidb table #47900

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

lkshminarayanan
Copy link
Contributor

@lkshminarayanan lkshminarayanan commented Oct 22, 2023

close #39778

What problem does this PR solve?

Issue Number: close #39778

Problem Summary:

What is changed and how it works?

Updated the bootstrap code to write the mDDLTableVersion value into the mysql.tidb table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-tests-checked labels Oct 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 22, 2023

Hi @lkshminarayanan. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2023
@tiprow
Copy link

tiprow bot commented Oct 22, 2023

Hi @lkshminarayanan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #47900 (3bd64b1) into master (b584055) will increase coverage by 1.3945%.
Report is 20 commits behind head on master.
The diff coverage is 86.9565%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47900        +/-   ##
================================================
+ Coverage   71.7482%   73.1428%   +1.3945%     
================================================
  Files          1400       1424        +24     
  Lines        405579     415249      +9670     
================================================
+ Hits         290996     303725     +12729     
+ Misses        94846      92613      -2233     
+ Partials      19737      18911       -826     
Flag Coverage Δ
integration 42.5345% <78.2608%> (?)
unit 72.1067% <86.9565%> (+0.3584%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8717% <ø> (-4.1698%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 25, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-25 01:10:30.130342302 +0000 UTC m=+2397027.717452449: ☑️ agreed by Defined2014.
  • 2023-10-25 02:29:44.19488141 +0000 UTC m=+2401781.781991540: ☑️ agreed by tangenta.

@lkshminarayanan
Copy link
Contributor Author

/cc @yudongusa

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

@lkshminarayanan: GitHub didn't allow me to request PR reviews from the following users: yudongusa.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yudongusa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta tangenta added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Oct 26, 2023
@easonn7
Copy link

easonn7 commented Oct 26, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, easonn7, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 26, 2023
@Defined2014
Copy link
Contributor

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 26, 2023

@Defined2014: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 26, 2023

@Defined2014: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit a565692 into pingcap:master Oct 26, 2023
14 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48012.

@lkshminarayanan lkshminarayanan deleted the write-ddl-table-version branch October 26, 2023 12:44
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display mDDLTableVersion in mysql.tidb table
6 participants