-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: display mDDLTableVersion in mysql.tidb table #47900
session: display mDDLTableVersion in mysql.tidb table #47900
Conversation
Hi @lkshminarayanan. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @lkshminarayanan. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47900 +/- ##
================================================
+ Coverage 71.7482% 73.1428% +1.3945%
================================================
Files 1400 1424 +24
Lines 405579 415249 +9670
================================================
+ Hits 290996 303725 +12729
+ Misses 94846 92613 -2233
+ Partials 19737 18911 -826
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e3c3398
to
3bd64b1
Compare
[LGTM Timeline notifier]Timeline:
|
/cc @yudongusa |
@lkshminarayanan: GitHub didn't allow me to request PR reviews from the following users: yudongusa. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, easonn7, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check-dev2 |
@Defined2014: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@Defined2014: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to a cherrypick label: new pull request created to branch |
close #39778
What problem does this PR solve?
Issue Number: close #39778
Problem Summary:
What is changed and how it works?
Updated the bootstrap code to write the
mDDLTableVersion
value into themysql.tidb
table.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.