ddl: no more sleep when meets nonRetryable error

[Defined2014]

What problem does this PR solve?

Issue Number: close #47455

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

run SQL below,

create table t ( obj json, arr json, nil json, t json, f json, i json, ui json, f64 json, str json, nul json );
insert into t values ('{\"obj\": 100}', '[-1, 0, 1]', 'null', 'true', 'false', '20200826173501', '20201123', '20200826173501.123456', '\"2020-08-26 17:35:01.123456\"', null);
alter table t modify obj datetime;

alter table return error directly, no more sleep.

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zimulala]

Could we remove job.IsCancelling()?

[Defined2014]

Done. This code also for speed up test before, so I removed it. #41034

[codecov]

Codecov Report

Merging #47461 (6fb21c0) into master (8772821) will increase coverage by 0.5819%.
Report is 4 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47461        +/-   ##
================================================
+ Coverage   72.1516%   72.7335%   +0.5819%     
================================================
  Files          1352       1373        +21     
  Lines        401072     407516      +6444     
================================================
+ Hits         289380     296401      +7021     
+ Misses        92450      92324       -126     
+ Partials      19242      18791       -451     

Flag	Coverage Δ
integration	39.3245% <20.0000%> (?)
unit	72.1482% <100.0000%> (-0.0034%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9913% <ø> (ø)
parser	84.6681% <ø> (+0.0107%)	⬆️
br	48.8540% <ø> (-4.3409%)	⬇️

[zimulala]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tangenta,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-10-09 02:05:10.798524289 +0000 UTC m=+1017908.385634418: ☑️ agreed by zimulala.
• 2023-10-09 02:31:58.343125041 +0000 UTC m=+1019515.930235186: ☑️ agreed by tangenta.