-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Add cast to ensure that the actual output type of builtin_control
is consistent with retType | tidb-test=pr/2216
#46786
Conversation
Hi @SeaRise. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
builtin_control
is consistent with retType
builtin_control
is consistent with retTypebuiltin_control
is consistent with retType
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46786 +/- ##
================================================
- Coverage 72.9964% 72.8408% -0.1557%
================================================
Files 1338 1359 +21
Lines 399462 407398 +7936
================================================
+ Hits 291593 296752 +5159
- Misses 89018 91922 +2904
+ Partials 18851 18724 -127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev2 |
@SeaRise: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@SeaRise: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@SeaRise: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@SeaRise: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@SeaRise: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Also resolves |
What problem does this PR solve?
Issue Number: close #44196
Problem Summary:
What is changed and how it works?
newBaseBuiltinFuncWithFieldTypes
InferType4ControlFuncs
and useInferType4ControlFuncs
incaseWhenFunctionClass::getFunction
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.