Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session, com_stmt: fetch all rows during EXECUTE command (#42473) #42518

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #42473

What problem does this PR solve?

Issue Number: close #42424, close #41891

What is changed and how it works?

  1. Fetch all rows and store them in the fetchedRows in the ResultSet.
  2. Close the result set in EXECUTE command, so we don't need to close it again in the following commands (FETCH, RESET and CLOSE)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Test with the following a little bigger table:

import java.math.BigDecimal;
import java.sql.*;

public class Example {
    public static void main(String[] args) throws SQLException, InterruptedException, Exception {
        Connection conn = DriverManager.getConnection("jdbc:mysql://127.0.0.1:4000/test?useCursorFetch=true&useServerPrepStmts=true&useSSL=false", "root", "");

        conn.setAutoCommit(false); // must set

        conn.prepareStatement("drop table if exists t").execute();
        conn.prepareStatement("create table t (id int primary key, id_2 int)").execute();

        for (int i = 0; i < 10000; i++) {
            PreparedStatement stmt = conn.prepareStatement("insert into t values (?, ?)");
            stmt.setInt(1, i);
            stmt.setInt(2, i);
            stmt.execute();
        }

        // submit a statement with more arguments:
        PreparedStatement statement1 = conn.prepareStatement("" +
                "select * " +
                "from " +
                "t " +
                "where id > ? and id_2 > ?");
        statement1.setFetchSize(500);
        statement1.setBigDecimal(1, new BigDecimal(2));
        statement1.setBigDecimal(2, new BigDecimal(2));
        ResultSet rs_1 = statement1.executeQuery();

        // submit a statement with less arguments:
        PreparedStatement statement2 = conn.prepareStatement("" +
                "select * " +
                "from " +
                "t " +
                "where (id > ?)");
        statement2.setFetchSize(500);
        statement2.setBigDecimal(1, new BigDecimal(1));
        ResultSet rs_2 = statement2.executeQuery();


        // fetch the result from the first argument
        int iter = 3;
        while (rs_1.next()) {
            int result = rs_1.getInt(1);

            if (result != iter++ ) {
                throw new Exception("");
            }
        }
        System.out.println(iter);
        iter = 2;
        while (rs_2.next()) {
            int result = rs_2.getInt(1);

            if (result != iter++ ) {
                throw new Exception("");
            }
        }
        System.out.println(iter);

        conn.commit();
        statement1.close();
        statement2.close();
        conn.close();
    }
}

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

It stores all rows of a cursor fetch statement locally, while execuing the EXECUTE command, so it will eat up more memory (related with the size of query).

Release note

Previously, TiDB loads data in `FETCH` command with the `cursorFetch` enabled. Now, TiDB will load all data into the memory in `EXECUTE` command. It'll use more memory according to the size of result. And also, TiDB will never report write conflict in `FETCH` command with read-committed isolation level.

@ti-chi-bot ti-chi-bot requested a review from a team as a code owner March 23, 2023 09:35
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Mar 23, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 23, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test b2821c8 link true /test unit-test
idc-jenkins-ci-tidb/check_dev b2821c8 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 b2821c8 link true /test check-dev2
idc-jenkins-ci-tidb/build b2821c8 link true /test build
idc-jenkins-ci-tidb/mysql-test b2821c8 link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@YangKeao
Copy link
Member

I'll submit a cherry-pick manually. Close this one.

@YangKeao YangKeao closed this Mar 27, 2023
@tiancaiamao
Copy link
Contributor

I'll submit a cherry-pick manually. Close this one.

#42602

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 23, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot May 23, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants