-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session, com_stmt: fetch all rows during EXECUTE command (#42473) #42518
session, com_stmt: fetch all rows during EXECUTE command (#42473) #42518
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I'll submit a cherry-pick manually. Close this one. |
|
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #42473
What problem does this PR solve?
Issue Number: close #42424, close #41891
What is changed and how it works?
fetchedRows
in theResultSet
.EXECUTE
command, so we don't need to close it again in the following commands (FETCH
,RESET
andCLOSE
)Check List
Tests
Test with the following a little bigger table:
Side effects
It stores all rows of a cursor fetch statement locally, while execuing the
EXECUTE
command, so it will eat up more memory (related with the size of query).Release note