-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: vectorized builtinSleepSig #15193
Conversation
Signed-off-by: Ziyi Yan <[email protected]>
Signed-off-by: Ziyi Yan <[email protected]>
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
Codecov Report
@@ Coverage Diff @@
## master #15193 +/- ##
===============================================
- Coverage 80.464% 80.4118% -0.0523%
===============================================
Files 503 503
Lines 133692 133361 -331
===============================================
- Hits 107574 107238 -336
- Misses 17710 17711 +1
- Partials 8408 8412 +4 |
PTAL @SunRunAway @XuHuaiyu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Thank you for the PR. I've left some comments.
And it would be nice if you add some unit tests.
Take a look at testEvaluatorSuite.TestSleep
and consider adding TestSleepVectorized
.
And there should be a test for comparison in builtin_miscellaneous_vec_test.go.
Signed-off-by: Ziyi Yan <[email protected]>
…vectorized implementation. Signed-off-by: Ziyi Yan <[email protected]>
Thanks for your suggestions @SunRunAway! I resolved them and PTAL. |
Hi, please consider adding unit tests described here #15193 (review). |
d21aff7
to
d0e31e0
Compare
Signed-off-by: Ziyi Yan <[email protected]> Signed-off-by: Ziyi Yan <[email protected]>
Signed-off-by: Ziyi Yan <[email protected]>
Signed-off-by: Ziyi Yan <[email protected]>
d0e31e0
to
3a63474
Compare
Signed-off-by: Ziyi Yan <[email protected]>
Finally, I got my own unit test passed. PTAL @SunRunAway 😁 |
Signed-off-by: Ziyi Yan <[email protected]>
Signed-off-by: Ziyi Yan <[email protected]>
Signed-off-by: Ziyi Yan <[email protected]>
Signed-off-by: Ziyi Yan <[email protected]>
Signed-off-by: Ziyi Yan <[email protected]>
PTAL @SunRunAway @qw4990 |
Signed-off-by: Ziyi Yan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, WELL DONE!
/run-all-tests |
UCP #12103
What problem does this PR solve?
Vectorized builtinSleepSig function from issue #12103
What is changed and how it works?
Implemented vecEvalInt method of builtinSleepSig
Check List
Tests