Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtinBitCountSig #13918

Closed
wants to merge 1 commit into from
Closed

builtinBitCountSig #13918

wants to merge 1 commit into from

Conversation

younfor
Copy link

@younfor younfor commented Dec 5, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinBitCountSig.
Issue #12103

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinOtherFuncGenerated-4   	1000000000	         0.0100 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinOtherFunc/builtinBitCountSig-VecBuiltinFunc-4            50288	     23415 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinOtherFunc/builtinBitCountSig-NonVecBuiltinFunc-4         31467	     38341 ns/op	       0 B/op	       0 allocs/op
PASS

Check List

Tests

  • Unit test

Change-Id: I97b4821e1b5462f8c0c53e7ab78aff2a39d59af7
@younfor younfor requested a review from a team as a code owner December 5, 2019 06:06
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 5, 2019
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team December 5, 2019 06:06
@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chenqi.seven seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@francis0407
Copy link
Member

Hi, this is duplicate to #13267. Could you please try other expressions?

@wshwsh12
Copy link
Contributor

wshwsh12 commented Dec 5, 2019

Duplicate of #13267

@wshwsh12 wshwsh12 marked this as a duplicate of #13267 Dec 5, 2019
@younfor younfor closed this Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #13918 into master will increase coverage by 0.0191%.
The diff coverage is 81.8181%.

@@               Coverage Diff                @@
##             master     #13918        +/-   ##
================================================
+ Coverage   80.2155%   80.2347%   +0.0191%     
================================================
  Files           480        480                
  Lines        118952     118855        -97     
================================================
- Hits          95418      95363        -55     
+ Misses        16007      15963        -44     
- Partials       7527       7529         +2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants