Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinConcatWSSig #13911

Closed
wants to merge 1 commit into from

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Dec 4, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinConcatWSSig.
Issue: #12106

What is changed and how it works?

BenchmarkVectorizedBuiltinStringFunc/builtinConcatWSSig-VecBuiltinFunc-4                                    6127            188824 ns/op    91888 B/op        1917 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinConcatWSSig-NonVecBuiltinFunc-4                                 6003            202023 ns/op    76624 B/op        1570 allocs/op

Check List

Tests

  • Unit test

@tangwz tangwz requested a review from a team as a code owner December 4, 2019 14:42
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 4, 2019
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team December 4, 2019 14:42
@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #13911 into master will decrease coverage by 0.0351%.
The diff coverage is 72.093%.

@@               Coverage Diff                @@
##             master     #13911        +/-   ##
================================================
- Coverage   80.2578%   80.2226%   -0.0352%     
================================================
  Files           480        480                
  Lines        118842     118853        +11     
================================================
- Hits          95380      95347        -33     
- Misses        15941      15971        +30     
- Partials       7521       7535        +14

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #13331

@tangwz tangwz closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants