Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinSubStringAndDurationSig #13836

Conversation

shihongzhi
Copy link
Member

@shihongzhi shihongzhi commented Dec 1, 2019

What problem does this PR solve?

implement vectorized evaluation for builtinSubStringAndDurationSig , for #12106

What is changed and how it works?

$go test -v -benchmem -bench=BenchmarkVectorizedBuiltinTimeFunc -run=BenchmarkVectorizedBuiltinTimeFunc -args "builtinSubStringAndDurationSig"
goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinTimeFuncGenerated-4           1000000000               0.0332 ns/op          0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSubStringAndDurationSig-VecBuiltinFunc-4                   518           2692707 ns/op          184037 B/op       8932 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSubStringAndDurationSig-NonVecBuiltinFunc-4                386           2679383 ns/op          184583 B/op       8932 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      4.340s

Tests

  • Unit test

@shihongzhi shihongzhi requested a review from a team as a code owner December 1, 2019 04:30
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team December 1, 2019 04:30
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 1, 2019
@shihongzhi shihongzhi changed the title expression: implement vectorized evaluation for bultinSubStringAndDurationSig expression: implement vectorized evaluation for builtinSubStringAndDurationSig Dec 1, 2019
@codecov
Copy link

codecov bot commented Dec 1, 2019

Codecov Report

Merging #13836 into master will decrease coverage by 0.2628%.
The diff coverage is 67.5%.

@@               Coverage Diff                @@
##             master     #13836        +/-   ##
================================================
- Coverage   80.4274%   80.1646%   -0.2629%     
================================================
  Files           474        474                
  Lines        118411     117089      -1322     
================================================
- Hits          95235      93864      -1371     
- Misses        15730      15816        +86     
+ Partials       7446       7409        -37

@wshwsh12 wshwsh12 removed their request for review December 4, 2019 03:39
@qw4990 qw4990 removed their request for review December 6, 2019 06:10
@shihongzhi
Copy link
Member Author

Duplicated with pr #13691

@shihongzhi shihongzhi closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants