Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinSubDateAndStringSig #13835

Conversation

shihongzhi
Copy link
Member

What problem does this PR solve?

implement vectorized evaluation for builtinSubDateAndStringSig , for #12106

What is changed and how it works?

$go test -v -benchmem -bench=BenchmarkVectorizedBuiltinTimeFunc -run=BenchmarkVectorizedBuiltinTimeFunc -args "builtinSubDateAndStringSig"
goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinTimeFuncGenerated-4           1000000000               0.0203 ns/op          0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSubDateAndStringSig-VecBuiltinFunc-4               655           1736516 ns/op          190230 B/op       9903 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSubDateAndStringSig-NonVecBuiltinFunc-4            607           1879569 ns/op          190025 B/op       9903 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      2.888s

Tests

  • Unit test

@shihongzhi shihongzhi requested a review from a team as a code owner November 30, 2019 14:45
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team November 30, 2019 14:45
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 30, 2019
@shihongzhi
Copy link
Member Author

/run-unit-test

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #13835 into master will decrease coverage by 0.2459%.
The diff coverage is 71.7948%.

@@               Coverage Diff               @@
##             master     #13835       +/-   ##
===============================================
- Coverage   80.4274%   80.1815%   -0.246%     
===============================================
  Files           474        474               
  Lines        118411     117088     -1323     
===============================================
- Hits          95235      93883     -1352     
- Misses        15730      15800       +70     
+ Partials       7446       7405       -41

@wshwsh12
Copy link
Contributor

wshwsh12 commented Dec 4, 2019

Thanks for your contribution. Sorry to reply you so late.
We can use go generate to implement the following functions at the same time. Would you like to try it?
You can see the docs https://docs.google.com/document/d/17XdYo_EwYaWANqbjS3i3OVSz3oLlovU2fIo1bRx4YqA/edit# to get more information.

builtinSubDateAndDurationSig
builtinSubDateAndStringSig
builtinSubDatetimeAndDurationSig
builtinSubDatetimeAndStringSig
builtinSubDurationAndDurationSig
builtinSubDurationAndStringSig
builtinSubStringAndDurationSig
builtinSubStringAndStringSig
builtinSubTimeDateTimeNullSig
builtinSubTimeDurationNullSig
builtinSubTimeStringNullSig

@wshwsh12 wshwsh12 removed their request for review December 4, 2019 03:38
@shihongzhi
Copy link
Member Author

Thanks for your contribution. Sorry to reply you so late.
We can use go generate to implement the following functions at the same time. Would you like to try it?
You can see the docs https://docs.google.com/document/d/17XdYo_EwYaWANqbjS3i3OVSz3oLlovU2fIo1bRx4YqA/edit# to get more information.

builtinSubDateAndDurationSig
builtinSubDateAndStringSig
builtinSubDatetimeAndDurationSig
builtinSubDatetimeAndStringSig
builtinSubDurationAndDurationSig
builtinSubDurationAndStringSig
builtinSubStringAndDurationSig
builtinSubStringAndStringSig
builtinSubTimeDateTimeNullSig
builtinSubTimeDurationNullSig
builtinSubTimeStringNullSig

I will try it.

@wshwsh12
Copy link
Contributor

wshwsh12 commented Dec 4, 2019

I will try it.

@shihongzhi Sorry, but .... someone is doing it . The pr is #13691.

@qw4990 qw4990 removed their request for review December 6, 2019 06:10
@shihongzhi
Copy link
Member Author

I will try it.

@shihongzhi Sorry, but .... someone is doing it . The pr is #13691.

okay. I close this PR

@shihongzhi shihongzhi closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants