Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinTimeLiteralSig #13816

Merged
merged 8 commits into from
Dec 6, 2019
Merged

expression: implement vectorized evaluation for builtinTimeLiteralSig #13816

merged 8 commits into from
Dec 6, 2019

Conversation

hsqlu
Copy link
Contributor

@hsqlu hsqlu commented Nov 29, 2019 •
edited
Loading

What problem does this PR solve?

Issue: #12176
Implement vectorized evaluation for builtinTimeLiteralSig.

What is changed and how it works?

BenchmarkVectorizedBuiltinTimeFunc/builtinTimeLiteralSig-VecBuiltinFunc-4                                 870201              1400 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinTimeLiteralSig-NonVecBuiltinFunc-4                               60595             17687 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@hsqlu hsqlu requested a review from a team as a code owner November 29, 2019 07:06
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 29, 2019
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team November 29, 2019 07:06
@codecov
Copy link

codecov bot commented Nov 29, 2019 •
edited
Loading

Codecov Report

Merging #13816 into master will increase coverage by 0.1064%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #13816        +/-   ##
================================================
+ Coverage   80.1463%   80.2527%   +0.1064%     
================================================
  Files           480        480                
  Lines        120028     119419       -609     
================================================
- Hits          96198      95837       -361     
+ Misses        16152      16065        -87     
+ Partials       7678       7517       -161

wshwsh12
wshwsh12 reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsqlu PTAL

expression/builtin_time_vec_test.go Outdated Show resolved Hide resolved
wshwsh12
wshwsh12 reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 5, 2019
qw4990
qw4990 approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 6, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit 67b4072 into pingcap:master Dec 6, 2019
eggeek pushed a commit to eggeek/tidb that referenced this pull request Dec 6, 2019
@hsqlu @eggeek
expression: implement vectorized evaluation for `builtinTimeLiteralSi…
ba3059d 
…g` (pingcap#13816)
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@hsqlu @XiaTianliang
expression: implement vectorized evaluation for `builtinTimeLiteralSi…
3a1f69d 
…g` (pingcap#13816)
@hsqlu hsqlu deleted the feature-vec-time-literal branch January 10, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsqlu @sre-bot @qw4990 @wshwsh12