expression: implement vectorized evaluation for builtinCastStringAsDurationSig
#13807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urationSig` expression: implement vectorized evaluation for `builtinCastStringAsDurationSig`
ghost
requested review from
qw4990 and
wshwsh12
and removed request for
a team
|
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #13807 +/- ##
===========================================
Coverage ? 80.1389%
===========================================
Files ? 474
Lines ? 117048
Branches ? 0
===========================================
Hits ? 93801
Misses ? 15844
Partials ? 7403 |
|
/rebuild |
|
@SilvaXiang, please update your pull request. |
|
Hi @SilvaXiang, please run |
francis0407
reviewed
Jan 19, 2020
expression/builtin_cast_vec_test.go
Outdated
| @@ -51,7 +51,6 @@ var vecBuiltinCastCases = map[string][]vecExprBenchCase{ | |||
| {retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETInt}, geners: []dataGenerator{new(randDurInt)}}, | |||
| {retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETReal}, geners: []dataGenerator{new(randDurReal)}}, | |||
| {retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETDecimal}, geners: []dataGenerator{new(randDurDecimal)}}, | |||
| {retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETString}, geners: []dataGenerator{new(randDurString)}}, | |||
There was a problem hiding this comment.
Why remove this? We need this test case actually.
|
@SilvaXiang, please update your pull request. |
1 similar comment
|
@SilvaXiang, please update your pull request. |
|
/run-all-tests |
hsqlu
pushed a commit
to hsqlu/tidb
that referenced
this pull request
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
expression: implement vectorized evaluation for
builtinCastStringAsDurationSigfrom #12176What is changed and how it works?
2.7% faster than before:
Check List
Tests