Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for 'builtinSubTimeDurationNullSig' #13704

Closed
wants to merge 1 commit into from
Closed

expression: implement vectorized evaluation for 'builtinSubTimeDurationNullSig' #13704

wants to merge 1 commit into from

Conversation

SilvaXiang
Copy link
Contributor

What problem does this PR solve?

Implement vectorized evaluation for builtinSubTimeDurationNullSig from #12176

What is changed and how it works?

99% faster than before:

BenchmarkVectorizedBuiltinTimeFunc/builtinSubTimeDurationNullSig-VecBuiltinFunc-4               13122880                88.4 ns/op             0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSubTimeDurationNullSig-NonVecBuiltinFunc-4              111243             11047 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@SilvaXiang
fix builtinSubTimeDurationNullSig
b10f2a1 
fix builtinSubTimeDurationNullSig
@SilvaXiang SilvaXiang requested a review from a team as a code owner November 23, 2019 03:56
@ghost ghost requested review from qw4990 and SunRunAway November 23, 2019 03:56
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 23, 2019
@ghost ghost removed their request for review November 23, 2019 03:56
@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #13704 into master will decrease coverage by 0.0006%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #13704        +/-   ##
================================================
- Coverage   79.9504%   79.9497%   -0.0007%     
================================================
  Files           473        473                
  Lines        116317     116318         +1     
================================================
  Hits          92996      92996                
+ Misses        15973      15971         -2     
- Partials       7348       7351         +3

francis0407
francis0407 reviewed Nov 23, 2019
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2019
@SunRunAway
Copy link
Contributor

@SilvaXiang builtinSubXXXAndYYYSig may be resolved by go generate, could you take a look at https://docs.google.com/document/d/17XdYo_EwYaWANqbjS3i3OVSz3oLlovU2fIo1bRx4YqA/edit#

@SunRunAway SunRunAway removed their request for review November 25, 2019 12:23
@qw4990 qw4990 removed their request for review November 26, 2019 07:37
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

@SilvaXiang, please update your pull request.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

@SilvaXiang, please update your pull request.

@SilvaXiang SilvaXiang closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francis0407 francis0407 francis0407 left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SilvaXiang @SunRunAway @sre-bot @francis0407 @zz-jason @qw4990