expression: implement vectorized evaluation for builtinConvSig
#13642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AerysNan <[email protected]>
|
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
SunRunAway
reviewed
Nov 25, 2019
| if negative && ignoreSign { | ||
| s = "-" + s | ||
| } | ||
| res := strings.ToUpper(s) |
There was a problem hiding this comment.
I've noticed that the most code is copied from builtinConvSig.evalString, could you warp a method and avoiding code copying?
| ast.Conv: { | ||
| { | ||
| retEvalType: types.ETString, | ||
| childrenTypes: []types.EvalType{types.ETString, types.ETInt, types.ETInt}, |
There was a problem hiding this comment.
We may need to limit the rune in arg[0] because the range of each rune should be [A-Z]|[0-9].
We may need to limit the bound of the arg[1] and arg[2] because the valid number is 2 to 36, maybe a range of [-1, 40] is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AerysNan [email protected]
PCP #12106
What problem does this PR solve?
Implement vectorized evaluation for builtinConvSig.
What is changed and how it works?
Check List
Tests