Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression:implement vectorized evaluation for builtinGetParamStringSig #13575

Merged
merged 5 commits into from
Nov 20, 2019

Conversation

icditwang
Copy link
Contributor

@icditwang icditwang commented Nov 19, 2019

PCP #12106

What problem does this PR solve?

implement vectorized evaluation for builtinGetParamStringSig

What is changed and how it works?

BenchmarkVectorizedBuiltinOtherFunc/builtinGetParamStringSig-VecBuiltinFunc-8         	    5634	    214450 ns/op	   45993 B/op	    1715 allocs/op
BenchmarkVectorizedBuiltinOtherFunc/builtinGetParamStringSig-NonVecBuiltinFunc-8      	    5121	    245058 ns/op	   45993 B/op	    1715 allocs/op

Check List

Tests

  • Unit test

@icditwang icditwang requested a review from a team as a code owner November 19, 2019 07:17
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@ghost ghost requested review from qw4990 and wshwsh12 November 19, 2019 07:17
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 19, 2019
@ghost ghost removed their request for review November 19, 2019 07:17
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #13575 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13575   +/-   ##
===========================================
  Coverage   79.9327%   79.9327%           
===========================================
  Files           473        473           
  Lines        115716     115716           
===========================================
  Hits          92495      92495           
  Misses        15955      15955           
  Partials       7266       7266

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

Your auto merge job has been accepted, waiting for 13506

@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

@icditwang merge failed.

@qw4990 qw4990 merged commit e4d199d into pingcap:master Nov 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

@icditwang complete task #12106 and get 50 score, currerent score 400.

@icditwang icditwang deleted the builtinGetParamStringSig branch November 20, 2019 09:54
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants