Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinAesDecryptIVSig #13557

Merged
merged 4 commits into from
Nov 26, 2019
Merged

expression: implement vectorized evaluation for builtinAesDecryptIVSig #13557

merged 4 commits into from
Nov 26, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Nov 18, 2019

PCP #12106

What problem does this PR solve?

implement vectorized evaluation for builtinAesDecryptIVSig from #12106

What is changed and how it works?

get about 10% faster

BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesDecryptIVSig-VecBuiltinFunc-12                            836           1410258 ns/op          611504 B/op       8057 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesDecryptIVSig-NonVecBuiltinFunc-12                         728           1571834 ns/op          622160 B/op       8723 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesDecryptIVSig-VecBuiltinFunc#01-12                        1752            622026 ns/op          755440 B/op       6790 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesDecryptIVSig-NonVecBuiltinFunc#01-12                     1666            673554 ns/op          769216 B/op       7469 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesDecryptIVSig-VecBuiltinFunc#02-12                        3466            314193 ns/op          413248 B/op       6690 allocs/op
BenchmarkVectorizedBuiltinEncryptionFunc/builtinAesDecryptIVSig-NonVecBuiltinFunc#02-12                     2956            361739 ns/op          427200 B/op       7359 allocs/op

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner November 18, 2019 15:36
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 18, 2019
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team November 18, 2019 15:37
@codecov
Copy link

codecov bot commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #13557 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #13557   +/-   ##
=========================================
  Coverage   80.093%   80.093%           
=========================================
  Files          474       474           
  Lines       116728    116728           
=========================================
  Hits         93491     93491           
  Misses       15856     15856           
  Partials      7381      7381

qw4990
qw4990 reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2019
@qw4990 qw4990 requested a review from Reminiscent November 26, 2019 08:22
@b41sh
Copy link
Member

b41sh commented Nov 26, 2019

LGTM

wshwsh12
wshwsh12 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit eae41ad into pingcap:master Nov 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

@js00070 complete task #12106 and get 50 score, currerent score 600.

qw4990 pushed a commit to qw4990/tidb that referenced this pull request Nov 27, 2019
@js00070 @qw4990
expression: implement vectorized evaluation for `builtinAesDecryptIVS…
7879279 
…ig` (pingcap#13557)
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 @XiaTianliang
expression: implement vectorized evaluation for `builtinAesDecryptIVS…
a1c00f6 
…ig` (pingcap#13557)
@js00070 js00070 deleted the builtinAesDecryptIVSig branch February 1, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@js00070 @sre-bot @b41sh @qw4990 @wshwsh12 @zz-jason