expression: implement vectorized evaluation for builtinDurationDurationTimeDiffSig
#12838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Codecov Report
@@ Coverage Diff @@
## master #12838 +/- ##
================================================
- Coverage 80.1069% 79.8991% -0.2079%
================================================
Files 465 465
Lines 107520 107632 +112
================================================
- Hits 86131 85997 -134
- Misses 14909 15142 +233
- Partials 6480 6493 +13 |
qw4990
reviewed
Oct 21, 2019
|
/run-all-tests |
|
/run-all-tests |
Reminiscent
reviewed
Oct 23, 2019
|
/run-all-tests |
|
@Reminiscent PTAL |
zz-jason
reviewed
Oct 28, 2019
| return err | ||
| } | ||
| defer b.bufAllocator.put(buf1) | ||
| if err := b.args[1].VecEvalDuration(b.ctx, input, buf1); err != nil { |
There was a problem hiding this comment.
we can use result to store one of the parameters, which helps us to reduce one memory allocation.
| continue | ||
| } | ||
| lhs := types.Duration{Duration: d64s[i]} | ||
| rhs := types.Duration{Duration: d64s1[i]} |
There was a problem hiding this comment.
we can define lhs and rhs outside the for loop, which saves two allocation for each loop iteration. It would improve the performance IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for builtinDurationDurationTimeDiffSig, for #12176
What is changed and how it works?
Check List
Tests