expression: implement vectorized evaluation for 'builtinNameConstRealSig' #12642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsthght
requested review from
qw4990,
Reminiscent,
SunRunAway and
XuHuaiyu
as code owners
Codecov Report
@@ Coverage Diff @@
## master #12642 +/- ##
===============================================
+ Coverage 79.9008% 79.9519% +0.051%
===============================================
Files 461 461
Lines 103940 104135 +195
===============================================
+ Hits 83049 83258 +209
+ Misses 14788 14769 -19
- Partials 6103 6108 +5 |
SunRunAway
added
component/expression
status/LGT1
qw4990
added
status/LGT2
qw4990
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 12657, 12658, 12659, 12641 |
|
/run-all-tests |
|
/run-integration-common-test |
qw4990
approved these changes
Oct 14, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinNameConstRealSig, for #12105
What is changed and how it works?
Check List
Tests