Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for 'builtinCastDurationAsDurationSig' #12630

Merged
merged 10 commits into from
Oct 16, 2019
Merged

expression: implement vectorized evaluation for 'builtinCastDurationAsDurationSig' #12630

merged 10 commits into from
Oct 16, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Oct 11, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinCastDurationAsDurationSig, for #12176

What is changed and how it works?

BenchmarkVectorizedBuiltinCastFunc/builtinCastDurationAsDurationSig-VecBuiltinFunc-8         	   20000	     81291 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastDurationAsDurationSig-NonVecBuiltinFunc-8      	   10000	    107914 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #12630 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12630   +/-   ##
===========================================
  Coverage   79.9015%   79.9015%           
===========================================
  Files           462        462           
  Lines        105187     105187           
===========================================
  Hits          84046      84046           
  Misses        14919      14919           
  Partials       6222       6222

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

@tsthght please merge the master branch and resolve the conflicts.

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 15, 2019
@zz-jason zz-jason removed the request for review from Reminiscent October 15, 2019 02:01
@tsthght tsthght requested a review from a team as a code owner October 15, 2019 05:25
@ghost ghost requested review from qw4990 and XuHuaiyu and removed request for a team October 15, 2019 05:25
@qw4990
Copy link
Contributor

qw4990 commented Oct 16, 2019

/run-unit-test

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4cca67c into pingcap:master Oct 16, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants