Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for 'builtinCastDecimalAsStringSig' #12537

Merged
merged 3 commits into from
Oct 8, 2019
Merged

expression: implement vectorized evaluation for 'builtinCastDecimalAsStringSig' #12537

merged 3 commits into from
Oct 8, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Oct 8, 2019 •
edited by qw4990
Loading

What problem does this PR solve?

Implement vectorized evaluation for builtinCastDecimalAsStringSig, for #12106

What is changed and how it works?

BenchmarkVectorizedBuiltinCastFunc/builtinCastDecimalAsStringSig-VecBuiltinFunc-8         	   20000	     99873 ns/op	   26272 B/op	     821 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastDecimalAsStringSig-NonVecBuiltinFunc-8      	   10000	    126724 ns/op	   51184 B/op	    1642 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 8, 2019
@codecov
Copy link

codecov bot commented Oct 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5754d2d). Click here to learn what that means.
The diff coverage is 57.6923%.

@@             Coverage Diff             @@
##             master     #12537   +/-   ##
===========================================
  Coverage          ?   79.8693%           
===========================================
  Files             ?        460           
  Lines             ?     102545           
  Branches          ?          0           
===========================================
  Hits              ?      81902           
  Misses            ?      14702           
  Partials          ?       5941

@qw4990 qw4990 changed the title expression: implement vectorized evaluation for 'builtinCastDecimalAs… expression: implement vectorized evaluation for 'builtinCastDecimalAsStringSig' Oct 8, 2019
qw4990
qw4990 reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 8, 2019
Reminiscent
Reminiscent approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

/run-all-tests

@sre-bot sre-bot merged commit 7aedd50 into pingcap:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsthght @sre-bot @qw4990 @Reminiscent