Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinReplaceSig #12496

Merged
merged 2 commits into from
Sep 30, 2019
Merged

expression: implement vectorized evaluation for builtinReplaceSig #12496

merged 2 commits into from
Sep 30, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Sep 30, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinReplaceSig.
12106

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinStringFunc/builtinReplaceSig-VecBuiltinFunc-4        18136     69507 ns/op
BenchmarkVectorizedBuiltinStringFunc/builtinReplaceSig-NonVecBuiltinFunc-4     10177    121940 ns/op

Check List

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 30, 2019
qw4990
qw4990 reviewed Sep 30, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reminiscent
Reminiscent approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 30, 2019
@codecov
Copy link

codecov bot commented Sep 30, 2019 •
edited
Loading

Codecov Report

Merging #12496 into master will decrease coverage by 0.4966%.
The diff coverage is 55.8823%.

@@               Coverage Diff                @@
##             master     #12496        +/-   ##
================================================
- Coverage   80.3324%   79.8358%   -0.4966%     
================================================
  Files           460        460                
  Lines        104248     102122      -2126     
================================================
- Hits          83745      81530      -2215     
- Misses        14560      14718       +158     
+ Partials       5943       5874        -69

@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2019

/run-all-tests

@sre-bot sre-bot merged commit b707447 into pingcap:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b41sh @sre-bot @qw4990 @Reminiscent