expression: implement vectorized evaluation for "builtinCastIntAsStringSig" #12425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
requested review from
Reminiscent and
qw4990
and removed request for
Reminiscent
Codecov Report
@@ Coverage Diff @@
## master #12425 +/- ##
================================================
+ Coverage 79.8676% 79.8974% +0.0297%
================================================
Files 460 460
Lines 102467 102360 -107
================================================
- Hits 81838 81783 -55
+ Misses 14698 14665 -33
+ Partials 5931 5912 -19 |
qw4990
reviewed
Sep 27, 2019
|
/run-unit-test |
qw4990
reviewed
Sep 27, 2019
qw4990
reviewed
Sep 27, 2019
|
/run-unit-test |
zz-jason
reviewed
Sep 28, 2019
zz-jason
reviewed
Sep 28, 2019
|
/run-unit-test |
|
/run-all-tests |
|
/run-common-test |
|
/run-integration-common-test |
|
/run-all-tests |
qw4990
reviewed
Sep 29, 2019
expression/builtin_cast_vec.go
Outdated
| if !isUnsigned { | ||
| str = strconv.FormatInt(i64s[i], 10) | ||
| } else { | ||
| u64, err := types.ConvertIntToUint(b.ctx.GetSessionVars().StmtCtx, i64s[i], types.IntergerUnsignedUpperBound(b.tp.Tp), b.tp.Tp) |
There was a problem hiding this comment.
Sorry, it's my fault.
It seems that we don't need ConvertIntToUint after reviewing the row-based implementation.
There was a problem hiding this comment.
ok, i will change ConvertIntToUint() to uint()
qw4990
reviewed
Sep 29, 2019
expression/builtin_cast_vec.go
Outdated
| } | ||
| str, err = types.ProduceStrWithSpecifiedTp(str, b.tp, b.ctx.GetSessionVars().StmtCtx, false) | ||
| if err != nil { | ||
| result.AppendNull() |
There was a problem hiding this comment.
We should throw this error here like the row-based implementation.
qw4990
reviewed
Sep 29, 2019
expression/builtin_cast_vec.go
Outdated
| var d bool | ||
| str, d, err = padZeroForBinaryType(str, b.tp, b.ctx) | ||
| if err != nil { | ||
| result.AppendNull() |
There was a problem hiding this comment.
ditto, we should throw this err here.
zz-jason
added
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinCastIntAsStringSig, for #12106
What is changed and how it works?
Check List
Tests