Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: generate vecEval methods for all functions to avoid further conflicts #12395

Merged
merged 12 commits into from
Sep 25, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 25, 2019

What problem does this PR solve?

Generate vecEval methods for all functions.

Check List

Tests

  • Unit test

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement. labels Sep 25, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Sep 25, 2019

/run-unit-test

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

Your auto merge job has been accepted, waiting for 12394

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 25, 2019

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit 7343287 into pingcap:master Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #12395 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12395   +/-   ##
===========================================
  Coverage   80.7404%   80.7404%           
===========================================
  Files           454        454           
  Lines         99639      99639           
===========================================
  Hits          80449      80449           
  Misses        13379      13379           
  Partials       5811       5811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants