Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinLeastIntSig #12286

Merged
merged 3 commits into from
Sep 22, 2019
Merged

expression: implement vectorized evaluation for builtinLeastIntSig #12286

merged 3 commits into from
Sep 22, 2019

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Sep 19, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinLeastIntSig.
Issue: #12103

What is changed and how it works?

BenchmarkVectorizedBuiltinCompareFunc/builtinLeastIntSig-VecBuiltinFunc-4             	  300000	      5311 ns/op
BenchmarkVectorizedBuiltinCompareFunc/builtinLeastIntSig-NonVecBuiltinFunc-4          	   50000	     33817 ns/op

Check List

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019 •
edited
Loading

Codecov Report

Merging #12286 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12286   +/-   ##
===========================================
  Coverage   81.0741%   81.0741%           
===========================================
  Files           454        454           
  Lines         98754      98754           
===========================================
  Hits          80064      80064           
  Misses        12909      12909           
  Partials       5781       5781

@tangwz
Copy link
Contributor Author

tangwz commented Sep 20, 2019

@qw4990 @SunRunAway PTAL

qw4990
qw4990 reviewed Sep 22, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SunRunAway
SunRunAway approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 22, 2019

/run-all-tests

@sre-bot sre-bot merged commit 8cb488a into pingcap:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tangwz @sre-bot @SunRunAway @qw4990