Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support vectorized bitmap operations for nulls in Column #12034

Merged
merged 8 commits into from
Sep 5, 2019
Merged

expression: support vectorized bitmap operations for nulls in Column #12034

merged 8 commits into from
Sep 5, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 5, 2019 •
edited
Loading

What problem does this PR solve?

Introduce a new method MergeNulls for Column.

What is changed and how it works?

BenchmarkMergeNullsVectorized-12         5000000               265 ns/op               0 B/op          0 allocs/op
BenchmarkMergeNullsNonVectorized-12       500000              3068 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited
Loading

Codecov Report

Merging #12034 into master will increase coverage by 0.041%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master     #12034       +/-   ##
===============================================
+ Coverage   81.3248%   81.3659%   +0.041%     
===============================================
  Files           447        447               
  Lines         95662      95583       -79     
===============================================
- Hits          77797      77772       -25     
+ Misses        12317      12284       -33     
+ Partials       5548       5527       -21

SunRunAway
SunRunAway reviewed Sep 5, 2019
View reviewed changes
util/chunk/column.go Outdated Show resolved Hide resolved
zz-jason
zz-jason reviewed Sep 5, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a UT.

SunRunAway
SunRunAway reviewed Sep 5, 2019
View reviewed changes
util/chunk/column.go Outdated Show resolved Hide resolved
SunRunAway
SunRunAway reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

@SunRunAway SunRunAway added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 5, 2019
SunRunAway
SunRunAway reviewed Sep 5, 2019
View reviewed changes
util/chunk/column_test.go Outdated Show resolved Hide resolved
util/chunk/column_test.go Outdated Show resolved Hide resolved
qw4990 and others added 2 commits September 5, 2019 15:36
SunRunAway
SunRunAway reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor

@qw4990 Please update PR description and benchmark result.

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 5, 2019
zz-jason
zz-jason approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2019

/run-all-tests

@qw4990 qw4990 removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 5, 2019
@qw4990 qw4990 added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 5, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Sep 5, 2019

@qw4990 Please update PR description and benchmark result.

Updated.

@sre-bot sre-bot merged commit 1b0f61a into pingcap:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@zz-jason zz-jason zz-jason approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @SunRunAway @sre-bot @zz-jason