Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-7.5 branch bump https://github.com/pingcap/errors to the latest commit hash #53517

Closed
3AceShowHand opened this issue May 23, 2024 · 1 comment · Fixed by #51854
Assignees
Labels
affects-7.5 sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@3AceShowHand
Copy link
Contributor

3AceShowHand commented May 23, 2024

Enhancement

tiflow release-7.5 bump tidb dependency to the commit-hash 9d27eef90bbb, the github.com/pingcap/errors is bumped to v0.11.5-0.20240318064555-6bd07397691f automatically.

but on the tidb release-7.5 branch 9d27eef90bbb, the errors package commit-hash is v0.11.5-0.20221009092201-b66cddb77c32, they are inconsistent.

Error reported:

# github.com/pingcap/tidb/br/pkg/redact
../pkg/mod/github.com/pingcap/[email protected]/br/pkg/redact/redact.go:14:32: cannot use redactLog (variable of type bool) as string value in argument to errors.RedactLogEnabled.Store
../pkg/mod/github.com/pingcap/[email protected]/br/pkg/redact/redact.go:19:9: cannot use errors.RedactLogEnabled.Load() (value of type string) as bool value in return statement
@Defined2014
Copy link
Contributor

I think the bug is fixed. If you still have problems, feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants