Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove mock.Context usage in ddl/internal/session/session_pool.go #53377

Closed
lcwangchao opened this issue May 20, 2024 · 0 comments · Fixed by #53378
Closed

remove mock.Context usage in ddl/internal/session/session_pool.go #53377

lcwangchao opened this issue May 20, 2024 · 0 comments · Fixed by #53378
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

Enhancement

It's better to remove mock.Context in production code. It should only be used in test
@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label May 20, 2024
@lcwangchao lcwangchao mentioned this issue May 20, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 20, 2024
@lcwangchao
ddl: remove mock.Context ref in ddl/session/session_pool.go (#53378)
dee4b45 
close #53377
terry1purcell pushed a commit to terry1purcell/tidb that referenced this issue May 20, 2024
@lcwangchao @terry1purcell
ddl: remove mock.Context ref in ddl/session/session_pool.go (ping…
37e4c86 
…cap#53378)

close pingcap#53377
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@lcwangchao @RidRisR
ddl: remove mock.Context ref in ddl/session/session_pool.go (ping…
8eec8ba 
…cap#53378)

close pingcap#53377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: remove mock.Context ref in ddl/session/session_pool.go lcwangchao/tidb
1 participant
@lcwangchao