Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The max value of token-limit should be more reasonable #53312

Closed
djshow832 opened this issue May 16, 2024 · 0 comments · Fixed by #53361
Closed

The max value of token-limit should be more reasonable #53312

djshow832 opened this issue May 16, 2024 · 0 comments · Fixed by #53361
Assignees
@djshow832
Labels
severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@djshow832
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Set the token-limit to the max value as specified in the doc: https://docs.pingcap.com/tidb/stable/tidb-configuration-file#token-limit

Maximum Value (64-bit platforms): 18446744073709551615
Maximum Value (32-bit platforms): 4294967295

2. What did you expect to see? (Required)

TiDB can start normally.

3. What did you see instead (Required)

TiDB OOM

4. What is your TiDB version? (Required)

master
@djshow832 djshow832 added type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra severity/moderate labels May 16, 2024
@djshow832 djshow832 mentioned this issue May 16, 2024
Closed
@djshow832 djshow832 self-assigned this May 17, 2024
@djshow832 djshow832 mentioned this issue May 17, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 17, 2024
@djshow832
config: set max token limit to 1M (#53361)
335af25 
close #53312
terry1purcell pushed a commit to terry1purcell/tidb that referenced this issue May 17, 2024
@djshow832 @terry1purcell
config: set max token limit to 1M (pingcap#53361)
61809f8 
close pingcap#53312
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@djshow832 @RidRisR
config: set max token limit to 1M (pingcap#53361)
9c4f3c5 
close pingcap#53312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djshow832 djshow832

Labels
severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: set max token limit to 1M djshow832/tidb
1 participant
@djshow832