Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3 RequestCanceled should be taken as graceful shutdown too #48635

Closed
D3Hunter opened this issue Nov 16, 2023 · 0 comments · Fixed by #48639
Closed

s3 RequestCanceled should be taken as graceful shutdown too #48635

D3Hunter opened this issue Nov 16, 2023 · 0 comments · Fixed by #48639
Labels
affects-7.5 component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

on graceful shutdown, err might returns from s3:

https://github.com/aws/aws-sdk-go/blob/9d1f49ba63bdac44a5b9f4d736e79d792e389e8a/aws/credentials/credentials.go#L246-L249

[2023/11/15 19:28:53.387 +08:00] [WARN] [s3.go:890] ["open new s3 reader failed"] [file=.....sysbench.user_data1.000001539.csv] [error="RequestCanceled: request context canceled\ncaused by: context canceled"]

2. What did you expect to see? (Required)

task keeps run

3. What did you see instead (Required)

failed

4. What is your TiDB version? (Required)

master
@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. component/ddl This issue is related to DDL of TiDB. affects-7.5 severity/major labels Nov 16, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Nov 16, 2023
@D3Hunter D3Hunter removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Nov 16, 2023
This was referenced Nov 16, 2023
Closed
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 16, 2023
@D3Hunter
disttask: add awserr. RequestCanceled as graceful shutdown err (#48639)
311d8a2 
close #48635
@ti-chi-bot ti-chi-bot mentioned this issue Nov 16, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 16, 2023
@ti-chi-bot
disttask: add awserr. RequestCanceled as graceful shutdown err (#48639)…
f2f232e 
… (#48648)

close #48635
@D3Hunter D3Hunter mentioned this issue Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disttask: add awserr. RequestCanceled as graceful shutdown err D3Hunter/tidb
1 participant
@D3Hunter